Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing address_index field to UnbondingTokensByAddressIndexRequest #4140

Merged
merged 2 commits into from
Mar 31, 2024

Conversation

jessepinho
Copy link
Contributor

@jessepinho jessepinho commented Mar 31, 2024

Describe your changes

While working on PR #4138, I forgot to include the address_index field in the request for unbonding tokens by address index. This PR fixes that.

Relevant changes are to the proto file here.

Issue ticket number and link

#4006

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Does not affect consensus

@erwanor erwanor added the protobuf-changes Makes changes to the protobuf definitions. label Mar 31, 2024
Copy link
Member

@erwanor erwanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge on green CI

@jessepinho jessepinho marked this pull request as ready for review March 31, 2024 00:02
@jessepinho jessepinho merged commit 6428659 into main Mar 31, 2024
7 checks passed
@jessepinho jessepinho deleted the jessepinho/address-index-missing-field branch March 31, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protobuf-changes Makes changes to the protobuf definitions.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants