Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex: fix incorrect nomenclature #4143

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Apr 1, 2024

Describe your changes

#4128 notes that we use the wrong terminology within the DEX, this PR fixes this by using a more precise nomenclature that reflects that each position is an AMM.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    client side changes

@erwanor erwanor added C-bug Category: a bug A-dex Area: Relates to the dex labels Apr 1, 2024
@erwanor erwanor added this to the Sprint 3 milestone Apr 1, 2024
@erwanor erwanor self-assigned this Apr 1, 2024
@erwanor erwanor merged commit d012f17 into main Apr 1, 2024
7 checks passed
@erwanor erwanor deleted the erwan/4128_fix_inaccurate_nomenclature branch April 1, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dex Area: Relates to the dex C-bug Category: a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants