feat(utils): implement v038 for tower-trace #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
approved these changes
Apr 4, 2024
github-merge-queue bot
pushed a commit
to astriaorg/astria
that referenced
this pull request
Apr 17, 2024
## Summary updates the sequencer app to use ABCI v0.38, which replaces `begin_block`/`deliver_tx`/`end_block` with one call, `finalize_block`. relevant penumbra PRs: - update penumbra-tower-trace to re-add instrumentation to the ABCI methods (done in penumbra-zone/penumbra#4160) - update cnidarium to be able to get the root hash of the state without calling `commit` (done in penumbra-zone/penumbra#4122) ## Background this was inevitable, also it cleans up the block execution flow inside the sequencer application. (removed `processed_txs` and `current_sequencer_block_builder` from the app) ## Changes - implement `finalize_block`; for the most part, I left the `begin_block`/`deliver_tx`/`end_block` as they are but called them inside `finalize_block` - however the block execution flow is cleaned up as we no longer need to track how many txs have been delivered (for the commitments) and we can construct the `SequencerBlock` at the end of `finalize_block` without needing to track things between calls ## Testing unit tests ran it with cometbft release [v0.38.6](https://github.com/cometbft/cometbft/releases/tag/v0.38.6) ## Breaking Changelist - the sequencer app will now only work with a cometbft version that supports ABCI v0.38 ## Related Issues closes #679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
implement support for ABCI v038 for the tower-trace util crate. required for eventual upgrade to ABCI v038 :)
Issue ticket number and link
n/a
Checklist before requesting a review
it only affects the tower-trace util crate