Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: fill in balance by action table #4165

Merged
merged 2 commits into from
Apr 10, 2024
Merged

spec: fill in balance by action table #4165

merged 2 commits into from
Apr 10, 2024

Conversation

redshiftzero
Copy link
Member

@redshiftzero redshiftzero commented Apr 5, 2024

Describe your changes

This PR fills in some TODOs in the table of balance contributions by action. I have gone through the other entries of the table and verified they are correct.

Issue ticket number and link

Closes #3991
Closes #1553

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: N/A

@cratelyn cratelyn added this to the Sprint 4 milestone Apr 8, 2024
@cratelyn cratelyn added the A-docs Area: Documentation needs for the project label Apr 8, 2024
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, @redshiftzero!

@redshiftzero redshiftzero merged commit 9d64dda into main Apr 10, 2024
7 checks passed
@redshiftzero redshiftzero deleted the 3991-spec-action branch April 10, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: Documentation needs for the project
Projects
Status: Done
2 participants