ci: add per-crate checks via cargo-hack #4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
force-pushed
the
ci-compile-each-crate-separately
branch
from
4e02841 to
41dce1e
Compare
cratelyn
added
the
A-CI/CD
conorsch
force-pushed
the
ci-compile-each-crate-separately
branch
from
08beb3b to
b06bb6e
Compare
conorsch
force-pushed
the
ci-compile-each-crate-separately
branch
from
b06bb6e to
29ae1dc
Compare
erwanor
reviewed
Apr 8, 2024
| @@ -1,6 +1,7 @@ | |||
| use anyhow::{Context, Result}; | |||
| use async_trait::async_trait; | |||
| use cnidarium::StateWrite; | |||
| #[cfg(feature = "component")] | |||
Suggested by @erwanor, based on the Astria CI config [0]. The goal is to ensure that our default feature sets actually work, by compiling each crate in the workspace individually. fix: feature-gating across the workspace Satisifes the new CI check by massaging the feature sets. [0] https://github.com/astriaorg/astria/blob/6cc8e2b828f8f5ee65e03c2b3383c4252b4c6b81/.github/workflows/test.yml#L64-L68
conorsch
force-pushed
the
ci-compile-each-crate-separately
branch
from
29ae1dc to
6a0c2bb
Compare
|
Running the new job with 8vcpus, which we can get away with because we use generous caching. After running the new CI job a few times, observed the following durations:
Let's keep an eye on it: we can always bump up the runner size if it's too slow. |
cratelyn
reviewed
Apr 8, 2024
cratelyn
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Suggested by @erwanor, based on the Astria CI config [0]. The goal is to ensure that our default feature sets actually work, by compiling each crate in the workspace individually.
[0] https://github.com/astriaorg/astria/blob/6cc8e2b828f8f5ee65e03c2b3383c4252b4c6b81/.github/workflows/test.yml#L64-L68
Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: