Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update several eol actions #4194

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Conversation

conorsch
Copy link
Contributor

Describe your changes

Changes made:

  • docker/login-action v2 -> v3
  • docker/metadata-action v4 -> v5
  • docker/build-push-action v3 -> v5
  • get-gke-credentials v1 -> v2
  • helmfile v1 -> v2
  • migrate actions-rs/toolchain -> dtolnay/rust-toolchain
  • remove docker/setup-qemu-action
  • remove battila7/get-version-action
  • removes unused container builds

All of these were showing warnings. These upgrades should have zero side-effects for our CI, but I'll check post-merge and confirm that.

Issue ticket number and link

Refs #3769, but does not close it: follow-up may be necessary post-merge, plus corresponding updates should be made across our repos.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    CI-only, no code changes

Changes made:

  * docker/login-action v2 -> v3
  * docker/metadata-action v4 -> v5
  * docker/build-push-action v3 -> v5
  * get-gke-credentials v1 -> v2
  * helmfile v1 -> v2
  * migrate actions-rs/toolchain -> dtolnay/rust-toolchain
  * remove docker/setup-qemu-action
  * remove battila7/get-version-action
  * removes unused container builds

All of these were showing warnings. These upgrades *should* have
zero side-effects for our CI, but I'll check post-merge and confirm
that.

Refs #3769, but does not close it: follow-up may be necessary
post-merge, plus corresponding updates should be made across our repos.
@conorsch conorsch added A-CI/CD Relates to continuous integration & deployment of Penumbra C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking. labels Apr 11, 2024
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for doing this! 🧹✨

@conorsch conorsch merged commit f0dba4c into main Apr 12, 2024
8 checks passed
@conorsch conorsch deleted the 3769-update-deprecated-ci-actions branch April 12, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI/CD Relates to continuous integration & deployment of Penumbra C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants