fix(asset): 🔊 Metadata: Debug includes all fields
#4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added
the
A-staking
fixes #4190. > The `Debug` impl for `asset::Metadata` throws away all data except for the base denom. This is extremely inconvenient for debugging. - #4190 --- this commit updates `Metadata`'s impl of `std::fmt::Debug` so that it includes all of the fields in the `Inner` structure. note for review: #4190 didn't explicitly mention which fields to include, so i have included all of them as a starting point. if we should find a middle ground, i am open and interested in hearing about that!
cratelyn
force-pushed
the
kate/metadata-debug-repr-includes-all-fields
branch
from
b5fc00a to
335d305
Compare
hdevalence
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
LGTM!
If we notice, as a result of this change, that there are places in the code where we're putting a ton of info in a tracing event (because we did ?metadata or something, relying on current behavior), we should change those to do the base denom or ID as appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4190.
this commit updates
Metadata's impl ofstd::fmt::Debugso that it includes all of the fields in theInnerstructure.note for review: #4190 didn't explicitly mention which fields to include, so i have included all of them as a starting point. if we should find a middle ground, i am open and interested in hearing about that!
issue ticket number and link
#4190
checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: