auction: define action balances #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
commented
Apr 16, 2024
| // The sequence number should always be >= 1, because we can | ||
| // only withdraw an auction that has ended (i.e. with sequence number `>=1`). | ||
| // We use a saturating operation defensively so that we don't underflow. | ||
| asset_id: AuctionNft::new(self.auction_id, self.seq.saturating_sub(1)).asset_id(), |
There was a problem hiding this comment.
@redshiftzero My rationale to do this is that we check the binding signature before we run any action validation checks, so even if this MUST be seq >= 1, we can't actually rely on that yet.
erwanor
commented
Apr 16, 2024
| pub fn new(id: AuctionId, seq: u64) -> AuctionNft { | ||
| let metadata = asset::REGISTRY | ||
| .parse_denom(&format!("auctionnft_{seq}_{id}")) | ||
| .expect("auction nft denom is valid"); |
There was a problem hiding this comment.
I think I want to do a second pass on both auction and lp nfts to make their constructor fallible.
redshiftzero
requested changes
Apr 16, 2024
redshiftzero
approved these changes
Apr 16, 2024
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR:
auctionnfts to the asset registryAuctionNftwith denom metadataDutchAuctionDescription::idbalancefor each actionIssue ticket number and link
This is a prelude to #4212
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: