pcli: fix terminal input in pcli threshold #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
force-pushed
the
fix-pcli-threshold-long-input
branch
from
5c12fcf to
d1d908e
Compare
erwanor
approved these changes
Apr 18, 2024
|
@conorsch can we pull this into the bugfix release or a soon-subsequent patch release? |
hdevalence
added a commit
that referenced
this pull request
Apr 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
When reading input from the terminal in
pcli thresholdcommands, circumvent OS-imposed restrictions on line length (required for interactive editing and notably low on MacOS) by dropping into "raw mode", reading the input a byte at a time and manually printing out the read byte to the user, then return to "cooked mode" (yes, that's what it's called) after detecting\nor\r.Issue ticket number and link
Closes #4230, which I confirmed through my own testing.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: