auction: extend view service #4236

TalDerei · 2024-04-18T13:42:38Z

Describe your changes

adds Auctions rpc interface that the transaction planner can query.

References #4227

If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

TalDerei · 2024-04-18T14:26:42Z

@erwanor what else should this PR encapsulate if we don't have access to a self.storage.request_auction_by_id storage implementation for instance?

erwanor

@TalDerei We can leave it as a stub for now, let's merge on green CI

TalDerei added 2 commits April 18, 2024 06:32

protos(auction): define rpc service and messages

6b3a398

regenerate protos

040a1e0

TalDerei had a problem deploying to smoke-test April 18, 2024 13:42 — with GitHub Actions Failure

TalDerei self-assigned this Apr 18, 2024

view service scaffold

457e3d5

TalDerei had a problem deploying to smoke-test April 18, 2024 14:14 — with GitHub Actions Error

unimplemented view service impl

a5f5c7e

TalDerei temporarily deployed to smoke-test April 18, 2024 14:23 — with GitHub Actions Inactive

erwanor approved these changes Apr 19, 2024

View reviewed changes

silence unused var in stub

98e43d1

TalDerei marked this pull request as ready for review April 19, 2024 15:13

cratelyn added this to the Sprint 4 milestone Apr 19, 2024

update and merge protos

054037e

TalDerei temporarily deployed to smoke-test April 19, 2024 23:37 — with GitHub Actions Inactive

more conflicts

113243d

TalDerei temporarily deployed to smoke-test April 20, 2024 00:01 — with GitHub Actions Inactive

TalDerei merged commit 514d30b into main Apr 20, 2024
8 checks passed

TalDerei deleted the auction-view-service branch April 20, 2024 00:35

cratelyn added the A-auction Area: Relates to the auction component label Apr 22, 2024