transaction: finalize auction integration #4237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
added
protobuf-changes
TalDerei
reviewed
Apr 19, 2024
| @@ -71,10 +71,9 @@ impl EffectingData for Action { | |||
| Action::CommunityPoolSpend(d) => d.effect_hash(), | |||
| Action::CommunityPoolOutput(d) => d.effect_hash(), | |||
| Action::CommunityPoolDeposit(d) => d.effect_hash(), | |||
| // TODO: fill in skeleton | |||
There was a problem hiding this comment.
remove extraneous comment
|
the functionality seems to be all there, LGTM! |
TalDerei
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR:
GasCostandIsActionimplsIssue ticket number and link
Part of #4212 + #4219
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: