-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): 🎋 add missing Sct
component hooks
#4246
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #3799. the `App` only ever invokes the Sct component's `init_chain` and `begin_block` hooks. this isn't currently a bug, since its `end_block` and `end_epoch` hooks are noöps, but could easily lead to a surprising outcome in the future, if more logic was introduced to those trait methods.
cratelyn
changed the title
feat(app): 🎋 add missing Sct component hooks
feat(app): 🎋 add missing Apr 19, 2024
Sct
component hooks
penumbra/crates/core/component/sct/src/component/sct.rs Lines 59 to 69 in c5e30cf
for reference: |
cratelyn
added a commit
that referenced
this pull request
Apr 19, 2024
see #3799, and #4246. while wiring up a pair of missing component hooks for the `Sct` component, i found another (noöp) hook that we do not include in the `App`'s control flow. this isn't currently a bug, since `<Dex as Component>::begin_block()` is a noöps but could easily lead to a surprising outcome in the future, if more logic was introduced to that trait method.
1 task
erwanor
approved these changes
Apr 19, 2024
cratelyn
added a commit
that referenced
this pull request
Apr 19, 2024
see #3739, and #4246. while wiring up a pair of missing component hooks for the `Sct` component, i found another (noöp) hook that we do not include in the `App`'s control flow. this isn't currently a bug, since `<Dex as Component>::begin_block()` is a noöps but could easily lead to a surprising outcome in the future, if more logic was introduced to that trait method. #### checklist before requesting a review - [x] if this code contains consensus-breaking changes, i have added the "consensus-breaking" label. otherwise, i declare my belief that there are not consensus-breaking changes, for the following reason: > while this **does** change the control flow of consensus-critical logic, this does **not** change the execution of incoming data. the hooks introduced here are noöps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3739.
the
App
only ever invokes the Sct component'sinit_chain
andbegin_block
hooks.this isn't currently a bug, since its
end_block
andend_epoch
hooks are noöps, but could easily lead to a surprising outcome in the future, if more logic was introduced to those trait methods.checklist before requesting a review
if this code contains consensus-breaking changes, i have added the "consensus-breaking" label. otherwise, i declare my belief that there are not consensus-breaking changes, for the following reason: