auction(pcli): auction support in pcli #4249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
reviewed
Apr 20, 2024
|
modifications to pcli docs will be handled separately |
|
flagging this workstream also has a dependency on having planner support #4241 |
erwanor
requested changes
Apr 20, 2024
There was a problem hiding this comment.
Thank you for the work you have put in this, I added a few comments that I think will make testing the core mechanism easier for us. I think at this point we just need to get the basic interface right, so if you want to replace the command impls with todo!() that would be ok.
6 tasks
|
LGTM, when we fill in the implementations we will want to ditch the nonce flag and use |
erwanor
approved these changes
Apr 22, 2024
erwanor
pushed a commit
that referenced
this pull request
Apr 24, 2024
## Describe your changes Auction support in pcli ## Issue ticket number and link References #4242 ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Auction support in pcli
Issue ticket number and link
References #4242
Checklist before requesting a review