Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR-001 for Dutch Auctions #4257

Merged
merged 2 commits into from
Apr 22, 2024
Merged

Add ADR-001 for Dutch Auctions #4257

merged 2 commits into from
Apr 22, 2024

Conversation

cronokirby
Copy link
Contributor

Describe your changes

This creates a new folder for storing architecture design records, as part of our documentation. This adds the recent Dutch Auction design description here. This should encourage people to write more of them as there's a clear place to put them now.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Just documentation.

@conorsch
Copy link
Contributor

Out of band, we've discussed storing ADRs in a separate repo, or even appending directly to the protocol docs. FWIW, I agree with the very simple approach here: just stick them in their own directory. At any point in the future, we can wrangle the files elsewhere.

Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to record this, @cronokirby!

@cratelyn cratelyn added A-docs Area: Documentation needs for the project A-auction Area: Relates to the auction component labels Apr 22, 2024
@cratelyn cratelyn added this to the Sprint 5 milestone Apr 22, 2024
@hdevalence
Copy link
Member

Can we call these PADR or something so they're not confused with cosmos ADRS?

@cronokirby
Copy link
Contributor Author

Can we call these PADR or something so they're not confused with cosmos ADRS?

Addressed

@cronokirby cronokirby merged commit fc7aac3 into main Apr 22, 2024
8 checks passed
@cronokirby cronokirby deleted the create-adr-folder branch April 22, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-auction Area: Relates to the auction component A-docs Area: Documentation needs for the project
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants