Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata: add tests for decoding failure when asset_id and denom don't match and simple roundtrip encoding test #4289

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

aubrika
Copy link
Contributor

@aubrika aubrika commented Apr 29, 2024

Closes #4191 - small PR to check a box on testing - we have an assert in play here in the conversion, but this test captures that the conversion does in fact error when these fields aren't consistent. Round-trip test added as a sanity check, not essential to the PR.

@aubrika aubrika marked this pull request as ready for review April 29, 2024 21:57
@aubrika aubrika merged commit 323b423 into main Apr 30, 2024
13 checks passed
@aubrika aubrika deleted the 4191-test-asset-id-denom-consistency branch April 30, 2024 17:15
@cratelyn cratelyn added this to the Sprint 5 milestone May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ensure we have test coverage for mismatched asset IDs in Metadata
3 participants