Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcli: improve auction rendering #4297

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented May 1, 2024

Describe your changes

This improve rendering of query/view subcommands for DAs. Helpful for testing and integration work.

Closes #4242, #4243, #4244

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Client changes

@erwanor erwanor requested a review from TalDerei May 1, 2024 15:48
@erwanor erwanor self-assigned this May 1, 2024
@erwanor erwanor added the A-auction Area: Relates to the auction component label May 1, 2024
@erwanor erwanor added this to the Sprint 5 milestone May 1, 2024
@TalDerei
Copy link
Collaborator

TalDerei commented May 1, 2024

Is this related to @jessepinho comment?

@erwanor
Copy link
Member Author

erwanor commented May 1, 2024

Nope but #4219 does

@erwanor erwanor merged commit 982f089 into main May 1, 2024
13 checks passed
@erwanor erwanor deleted the erwan/render_auction_positions branch May 1, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-auction Area: Relates to the auction component
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

pcli: support for auction interactions
2 participants