view: port wasm planner to core #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Tal Derei <70081547+TalDerei@users.noreply.github.com>
Co-Authored-By: Tal Derei <70081547+TalDerei@users.noreply.github.com>
Co-Authored-By: Tal Derei <70081547+TalDerei@users.noreply.github.com>
Co-Authored-By: Tal Derei <70081547+TalDerei@users.noreply.github.com>
|
with the governance passing, do we want to change the base branch in this PR? |
|
Exciting, good job, can you edit the title/description and we'll send it |
TalDerei
changed the title
erwanor
changed the title
erwanor
added
A-client
This was referenced May 3, 2024
|
cc @cratelyn |
This was referenced May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds a port of the wasm planner, integrating it within the
penumbra-viewcrate.SwapClaimhandlingIn the process of porting this PR, we found a bug in the handling of
SwapClaimactions with the wasm planner.SwapClaimactions produce surplus value from their prepaid fees) that must be released so that the transaction balance to zero. In principle, it should be possible to release this value into an output note. This isn't the approach we took with this PR. Instead, we release it to the transaction fee, providing a base for us to improve on later. This will be tracked by #4313.Issue ticket number and link
References #4081
Checklist before requesting a review