Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: updates per internal feedback #4334

Merged
merged 20 commits into from
May 9, 2024
Merged

spec: updates per internal feedback #4334

merged 20 commits into from
May 9, 2024

Conversation

redshiftzero
Copy link
Member

@redshiftzero redshiftzero commented May 6, 2024

Describe your changes

This PR contains protocol spec changes from internal feedback

Issue ticket number and link

Related to #4280
Closes #4342

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    spec only

@redshiftzero redshiftzero added this to the Sprint 6 milestone May 6, 2024
@redshiftzero redshiftzero self-assigned this May 6, 2024
@redshiftzero redshiftzero changed the title wip: updates to spec per internal feedback spec: updates per internal feedback May 8, 2024
@redshiftzero redshiftzero marked this pull request as ready for review May 8, 2024 17:40
@hdevalence
Copy link
Member

I'm not sure these should go in the protocol spec but they would be a great addition to the Respurces section of the guide!

docs/protocol/src/dex/action/swap_claim.md Outdated Show resolved Hide resolved
Signed-off-by: Lúcás Meier <cronokirby@gmail.com>
@redshiftzero redshiftzero merged commit 8627659 into main May 9, 2024
13 checks passed
@redshiftzero redshiftzero deleted the spec-updates-1 branch May 9, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Protocol spec incorrectly refers to Swap NFTs
4 participants