pd(migrate): add auction parameters to chain state for Testnet74
#4338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
added
migration
hdevalence
approved these changes
May 7, 2024
1 task
conorsch
added a commit
that referenced
this pull request
May 7, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. Still seeing some proto incompat post-migration, via the test runs, which appears to match the report in #4340.
conorsch
added a commit
that referenced
this pull request
May 7, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. Still seeing some proto incompat post-migration, via the test runs, which appears to match the report in #4340.
conorsch
added a commit
that referenced
this pull request
May 7, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. Still seeing some proto incompat post-migration, via the test runs, which appears to match the report in #4340.
conorsch
added a commit
that referenced
this pull request
May 7, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. Still seeing some proto incompat post-migration, via the test runs, which appears to match the report in #4340.
conorsch
added a commit
that referenced
this pull request
May 7, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. Still seeing some proto incompat post-migration, via the test runs, which appears to match the report in #4340.
conorsch
added a commit
that referenced
this pull request
May 7, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. Still seeing some proto incompat post-migration, via the test runs, which appears to match the report in #4340.
conorsch
added a commit
that referenced
this pull request
May 8, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. That logic still TK.
conorsch
added a commit
that referenced
this pull request
May 8, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. That logic still TK.
conorsch
added a commit
that referenced
this pull request
May 8, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now.
conorsch
added a commit
that referenced
this pull request
May 8, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now.
conorsch
added a commit
that referenced
this pull request
May 9, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. Next up: still trying to wrangle a migrated-state archive so that a fresh node can join, via `pd testnet join --archive-url`. Don't have that working yet.
conorsch
added a commit
that referenced
this pull request
May 9, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. Next up: still trying to wrangle a migrated-state archive so that a fresh node can join, via `pd testnet join --archive-url`. Don't have that working yet.
conorsch
added a commit
that referenced
this pull request
May 9, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 9, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 9, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 9, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 21, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 21, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 21, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 21, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 22, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 23, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 24, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 24, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 29, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 29, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 29, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
conorsch
added a commit
that referenced
this pull request
May 29, 2024
Building on the smoke-test rewrite to use process-compose, let's script the migration process, so that we can test current HEAD of the monorepo against a prior tagged version, and validate that necessary migrations are in place. One possible approach is to fetch prebuilt binaries from uploaded artifacts on Github. That's fine for `pd`, but doesn't work for running the smoke tests, due to client/server incompatibility. Therefore we'll clone the entire repo in a git-ignored subdir, and build the old binaries there. Heavy, but reliable. Updated to use the concise `pd migrate` UX from #4339. Previously, there were missing AuctionParams, resolved by #4338. It's imperative that we use the vote-to-halt mechanism to prepare for the upgrade, otherwise the priv validator state munging will not work. feat: migration-test crate Strictly for running the migration-test suite of integration tests, very similar in nature to the network-integration tests AKA smoke tests. tests. Copy/pastes a lot of code from the smokes, which we can always factor out into reusable utils, but not bothering with that right now. feat: create and host local migration archive, for join assertion We need to confirm that post-migration, new-joining nodes can peer with the network and stream blocks. To do so, we must create and host a tarball of archived state. We do that locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
@hdevalence noticed that we were missing a migration for the
AuctionParameters. This PR adds a migration to write the parameters to the app state.Issue ticket number and link
This was a miss in #4259
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: