-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
view: 👀 introduce more tracing instrumentation #4349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NB: this adds a `tap` dependency to the `penumbra-view` crate too.
cratelyn
added
A-node
Area: System design and implementation for node software
C-enhancement
Category: an enhancement to the codebase
A-telemetry
Area: Metrics, logging, and other observability-related features
labels
May 7, 2024
hdevalence
reviewed
May 8, 2024
hdevalence
reviewed
May 8, 2024
hdevalence
approved these changes
May 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
#4349 (comment) #4349 (comment) Co-Authored-By: Henry de Valence <hdevalence@penumbralabs.xyz>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-node
Area: System design and implementation for node software
A-telemetry
Area: Metrics, logging, and other observability-related features
C-enhancement
Category: an enhancement to the codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
describe your changes
this introduces some additional
tracing
instrumentation, used while debuggingintegration with the view server in mock consensus tests. because these events
may be useful more broadly, and aren't strictly tied to testing, this is
cherry-picked out of that work for separate consideration.
issue ticket number and link
checklist before requesting a review
this branch only makes changes to tracing spans and events. as this is
only altering telemetry, this is not consensus-breaking.