pcli: implement gda with predefined recipes #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
added
A-client
erwanor
changed the title
Co-Authored-By: Henry de Valence <44879+hdevalence@users.noreply.github.com>
erwanor
force-pushed
the
erwan/pcli_gda_prototype
branch
from
772cfde to
0fb3543
Compare
cratelyn
reviewed
May 9, 2024
Comment on lines
+29
to
+31
| /// Schedule a gradual dutch auction, a prototype for penumbra developers. | ||
| #[clap(display_order = 1000, name = "gradual")] | ||
| DutchAuctionGradualSchedule { |
There was a problem hiding this comment.
being unfamiliar with dutch auction literature, it might be friendly to provide a sentence or two about what a "gradual" auction is and particularly how it differs from a standard dutch auction.
cratelyn
approved these changes
May 9, 2024
|
Thanks for taking a look, good feedback, at this point this is an internal r&d prototype but polishing thing certainly wouldn't hurt |
cratelyn
added a commit
that referenced
this pull request
May 10, 2024
cratelyn
added a commit
that referenced
this pull request
May 10, 2024
erwanor
pushed a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR:
pcli tx auction dutch gradualIssue ticket number and link
#4302
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: