auction(vcb): add a value circuit breaker #4363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
added
consensus-breaking
27 tasks
TalDerei
approved these changes
May 9, 2024
There was a problem hiding this comment.
As a point of process, Erwan conducted an impromptu pairing session where we discussed some high level goals of this PR: 1. from first principles, make sure we identify all the proper junction points in the flow tracking, and 2. make sure we properly track the inflows and outflows of value in these junction points. We then discussed and sanity checked the value transfer to / from the auction / dex components.
|
We missed a juncture point which is when a user submitted action cause an auction to end early, in that case the component's value balance needs to be credited. x-ref #4388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds a value circuit breaker, modeled after the dex component's.
Issue ticket number and link
#4356
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: