Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

penumbra: use core.auction.v1 #4368

Merged
merged 7 commits into from
May 9, 2024
Merged

penumbra: use core.auction.v1 #4368

merged 7 commits into from
May 9, 2024

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented May 9, 2024

Describe your changes

This tags a v1 protobuf package for the auction component.

It includes a breaking changes to penumbra.v1 since we use the new v1 package to directly replace the previous references to the auction component in the app, view, transaction, and governance components. This is an exceptional deviation from process because this project was in active development with a single consumer.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    This change is both proto-breaking, consensus-breaking, and technically state-breaking. It doesn't require a migration because we never deployed these changes to our testnet.

@erwanor erwanor added A-node Area: System design and implementation for node software consensus-breaking breaking change to execution of on-chain data protobuf-breaking-changes Makes breaking changes to the protobuf definitions. state-breaking breaking change to on-chain data A-auction Area: Relates to the auction component labels May 9, 2024
@erwanor erwanor added this to the Sprint 6 milestone May 9, 2024
@erwanor erwanor requested a review from conorsch May 9, 2024 18:45
@erwanor erwanor self-assigned this May 9, 2024
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The buf-lint job is failing, which is expected: we're moving proto versions. But the change is narrowly scoped to affect only the auction interfaces, which is what we want. Other CI jobs must pass, though.

@conorsch
Copy link
Contributor

conorsch commented May 9, 2024

Other CI jobs must pass, though.

Confirmed.

@conorsch conorsch merged commit d13d731 into main May 9, 2024
12 of 13 checks passed
@conorsch conorsch deleted the erwan/v1_auction branch May 9, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-auction Area: Relates to the auction component A-node Area: System design and implementation for node software consensus-breaking breaking change to execution of on-chain data protobuf-breaking-changes Makes breaking changes to the protobuf definitions. state-breaking breaking change to on-chain data
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants