Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare testnet 75 #4375

Merged
merged 1 commit into from
May 10, 2024
Merged

chore: prepare testnet 75 #4375

merged 1 commit into from
May 10, 2024

Conversation

conorsch
Copy link
Contributor

Describe your changes

Makes three substantive changes:

  • resets TOTAL_HALT_COUNT to 0
  • increments APP_VERSION
  • increments chain_id penumbra-testnet-deimos-7 -> penumbra-testnet-deimos-8

There are multiple chain id directories included, pulled from the release/v0.73.2 tag. Due to our multi-branch workflow, we never backported those testnet configs to the main branch, but doing so is necessary now that we're releasing from main again.

Refs #4374.

Issue ticket number and link

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    This PR is in prep for a full chain reset.

Makes three substantive changes:

  * resets `TOTAL_HALT_COUNT` to 0
  * increments `APP_VERSION`
  * increments chain_id `penumbra-testnet-deimos-7` ->
    `penumbra-testnet-deimos-8`

There are multiple chain id directories included, pulled from the
`release/v0.73.2` tag. Due to our multi-branch workflow, we never
backported those testnet configs to the main branch, but doing so
is necessary now that we're releasing from main again.

Refs #4374.
@@ -3,3 +3,4 @@
| 1 (Testnet 70) | v0.70.x | v0.37.5 | v1 |
| 2 (Testnet 73) | v0.73.x | v0.37.5 | v1 |
| 3 (Testnet 74) | v0.74.x | v0.37.5 | v1 |
| 4 (Testnet 75) | v0.75.x | v0.37.5 | v1 |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping crate version only in the COMPAT doc for now. Post-merge, we'll bump-and-tag directly on the main branch, to trigger the release.

@cratelyn cratelyn added the C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking. label May 10, 2024
@cratelyn cratelyn added this to the Sprint 6 milestone May 10, 2024
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are multiple chain id directories included, pulled from the release/v0.73.2 tag. Due to our multi-branch workflow, we never backported those testnet configs to the main branch, but doing so is necessary now that we're releasing from main again.

thanks for explaining the backing context. this looks great.

@cratelyn
Copy link
Contributor

cratelyn commented May 10, 2024

one non-blocking question, since github review does not provide a nice way to hang comments on a parent directory:

for extra clarity, i might suggest that we leave e.g. an empty tombstone / stub directory, testnets/074-deimos-7. this could contain a small README.md containing a small memorandum about why that migration failed, noting that the jump from 73 to 75 was intentional and related to an operational issue.

@conorsch
Copy link
Contributor Author

for extra clarity, i might suggest that we leave e.g. an empty tombstone / stub directory, testnets/074-deimos-7. this could contain a small README.md containing a small memorandum about why that migration failed, noting that the jump from 73 to 75 was intentional and related to an operational issue.

This is a good suggestion! There are similar events would could backfill for posterity. The testnet dirs themselves are machine-readable, and their contents are baked into binaries, so I'd prefer to keep READMEs out of band. But a file in testnets/ recording the history is a gift to future maintainers, for sure.

@conorsch conorsch merged commit 0f34970 into main May 10, 2024
13 checks passed
@conorsch conorsch deleted the prep-testnet-75 branch May 10, 2024 15:58
@cratelyn
Copy link
Contributor

for extra clarity, i might suggest that we leave e.g. an empty tombstone / stub directory, testnets/074-deimos-7. this could contain a small README.md containing a small memorandum about why that migration failed, noting that the jump from 73 to 75 was intentional and related to an operational issue.

This is a good suggestion! There are similar events would could backfill for posterity. The testnet dirs themselves are machine-readable, and their contents are baked into binaries, so I'd prefer to keep READMEs out of band. But a file in testnets/ recording the history is a gift to future maintainers, for sure.

ah-ha! that is very good to know, had not realized these directories are machine-readable. knowing that, i agree with that plan of action. thank you for elaborating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants