Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: 🩹 add missing " to pid expansion #4382

Merged
merged 1 commit into from
May 13, 2024

Conversation

cratelyn
Copy link
Contributor

addendum to #4358.

checklist before requesting a review

  • if this code contains consensus-breaking changes, i have added the "consensus-breaking" label. otherwise, i declare my belief that there are not consensus-breaking changes, for the following reason:

    this only makes a change to ci scripts.

@cratelyn cratelyn self-assigned this May 12, 2024
@cratelyn cratelyn added A-CI/CD Relates to continuous integration & deployment of Penumbra C-bug Category: a bug labels May 12, 2024
@cratelyn cratelyn added this to the Sprint 6 milestone May 12, 2024
@cratelyn
Copy link
Contributor Author

noticed this in https://github.com/penumbra-zone/penumbra/actions/runs/9036580908/job/24833738240

./deployments/scripts/smoke-summoner.sh: exit trap: line 1: unexpected EOF while looking for matching `"'

@conorsch conorsch marked this pull request as ready for review May 13, 2024 16:56
@conorsch conorsch self-requested a review May 13, 2024 16:56
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shellcheck's happy, I'm happy.

@conorsch conorsch merged commit 0c60483 into main May 13, 2024
13 checks passed
@conorsch conorsch deleted the kate/smoke-summoner-trap-fixup branch May 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI/CD Relates to continuous integration & deployment of Penumbra C-bug Category: a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants