Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix rust-docs build #4415

Merged
merged 1 commit into from
May 20, 2024
Merged

ci: fix rust-docs build #4415

merged 1 commit into from
May 20, 2024

Conversation

conorsch
Copy link
Contributor

Describe your changes

Bumped the time crate in order to resolve a build error with recent rust nightlies on the rust-docs build. Also removed the index.html file generated for rust-docs from version control, since that file is built on the fly in CI post-merge, and so will always be out of date.

Issue ticket number and link

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    small version bump of a dependency, no changes to application logic

Bumped the `time` crate in order to resolve a build error with
recent rust nightlies on the `rust-docs` build. Also removed
the `index.html` file generated for rust-docs from version control,
since that file is built on the fly in CI post-merge, and so will always
be out of date.
@conorsch conorsch added the A-CI/CD Relates to continuous integration & deployment of Penumbra label May 20, 2024
@conorsch conorsch added the C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking. label May 20, 2024
@conorsch
Copy link
Contributor Author

See example failing build here: https://github.com/penumbra-zone/penumbra/actions/runs/9158128504/job/25175841362?pr=4413 the Docs lint job should pass on this PR.

@conorsch conorsch merged commit 4529ab5 into main May 20, 2024
13 checks passed
@conorsch conorsch deleted the debug-rust-docs-2024-05-20 branch May 20, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI/CD Relates to continuous integration & deployment of Penumbra C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants