Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update static sites #4427

Merged
merged 1 commit into from
May 21, 2024
Merged

Update static sites #4427

merged 1 commit into from
May 21, 2024

Conversation

grod220
Copy link
Contributor

@grod220 grod220 commented May 21, 2024

Describe your changes

Pulls latest node status + minifront app (commit e35c6f7) and updates them on PD.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
    • Only changing static sites

@grod220 grod220 self-assigned this May 21, 2024
@conorsch
Copy link
Contributor

Confirmed locally that the node-status page is rendering fine:

node-status-pr-4427

That's in addition to the "200 OK" sanity check test we added back in #4139. If there's anything else I should be looking for specifically, holler @grod220 , otherwise LGTM!

@grod220 grod220 mentioned this pull request May 21, 2024
Closed
40 tasks
@conorsch conorsch merged commit 1c602f8 into main May 21, 2024
13 checks passed
@conorsch conorsch deleted the update-static-sites branch May 21, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch conorsch approved these changes

Assignees

@grod220 grod220

Labels
None yet
Projects
Penumbra
Status: Done
Penumbra web
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grod220 @conorsch