Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex: deduct arb surplus from component VCB #4428

Merged
merged 4 commits into from
May 21, 2024
Merged

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented May 21, 2024

Describe your changes

Close #4113

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    This is consensus-breaking and state-breaking, but does not require any migration to heal the dex vcb

@erwanor erwanor added consensus-breaking breaking change to execution of on-chain data A-dex Area: Relates to the dex state-breaking breaking change to on-chain data labels May 21, 2024
@erwanor erwanor self-assigned this May 21, 2024
@erwanor erwanor requested a review from hdevalence May 21, 2024 20:28
@erwanor erwanor marked this pull request as ready for review May 21, 2024 20:28
Copy link
Member

@hdevalence hdevalence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erwanor erwanor merged commit c7e1ad8 into main May 21, 2024
13 checks passed
@erwanor erwanor deleted the erwan/4113_arb_execution_fix branch May 21, 2024 20:48
@erwanor erwanor added the migration A pull request that contains a migration label Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dex Area: Relates to the dex consensus-breaking breaking change to execution of on-chain data migration A pull request that contains a migration state-breaking breaking change to on-chain data
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Arb execution does not update value circuit breaker
2 participants