Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view: 🧿 add trace spans to ViewService methods #4435

Merged
merged 1 commit into from
May 22, 2024

Conversation

cratelyn
Copy link
Contributor

these are useful for the sake of following the sequence of function calls when debugging issues related to the view server, the view server worker, and integration tests making use of the Planner.

x-ref: #3913

checklist before requesting a review

  • if this code contains consensus-breaking changes, i have added the "consensus-breaking" label. otherwise, i declare my belief that there are not consensus-breaking changes, for the following reason:

    this is only making changes to the view server, consensus should not be affected.

these are useful for the sake of following the sequence of function
calls when debugging issues related to the view server, the view server
worker, and integration tests making use of the `Planner`.

x-ref: #3913
@cratelyn cratelyn added the A-client Area: Design and implementation for client functionality label May 22, 2024
@cratelyn cratelyn added this to the Sprint 7 milestone May 22, 2024
@cratelyn cratelyn self-assigned this May 22, 2024
@cratelyn cratelyn marked this pull request as ready for review May 22, 2024 06:40
@cratelyn cratelyn merged commit 7611ac3 into main May 22, 2024
13 checks passed
@cratelyn cratelyn deleted the kate/add-view-service-trace-spans branch May 22, 2024 12:47
cratelyn added a commit that referenced this pull request May 24, 2024
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
cratelyn added a commit that referenced this pull request May 29, 2024
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
cratelyn added a commit that referenced this pull request May 30, 2024
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
cratelyn added a commit that referenced this pull request May 31, 2024
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
cratelyn added a commit that referenced this pull request May 31, 2024
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
cratelyn added a commit that referenced this pull request Jun 3, 2024
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: Design and implementation for client functionality
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants