Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset: add asset.v1.Metadata.priority_score #4441

Merged
merged 1 commit into from
May 24, 2024
Merged

Conversation

hdevalence
Copy link
Member

Describe your changes

This is intended to help support clients that need to display lists of assets. An asset registry can assign rankings to tokens, and frontend software can consume them without needing to have its own opinions about what the ranking should be. For instance, a registry could have hardcoded "tiers" or priorities, or priorities assigned by market cap, or the user's balances, etc.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    This adds a new optional field to the proto which is used on-chain but never populates it with a non-default value, so encodings should not change.

Copy link
Contributor

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cratelyn cratelyn added the protobuf-changes Makes changes to the protobuf definitions. label May 23, 2024
@cratelyn cratelyn added this to the Sprint 7 milestone May 23, 2024
This is intended to help support clients that need to display lists of assets.
An asset registry can assign rankings to tokens, and frontend software can
consume them without needing to have its own opinions about what the ranking
should be. For instance, a registry could have hardcoded "tiers" or priorities,
or priorities assigned by market cap, or the user's balances, etc.
@erwanor erwanor force-pushed the metadata-priority-score branch from 5175e6f to 085539c Compare May 24, 2024 15:43
@conorsch conorsch merged commit 974dd5d into main May 24, 2024
13 checks passed
@conorsch conorsch deleted the metadata-priority-score branch May 24, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protobuf-changes Makes changes to the protobuf definitions.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants