Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

view: 🔎 add tracing telemetry to view server #4468

Merged
merged 4 commits into from
May 28, 2024
Merged

view: 🔎 add tracing telemetry to view server #4468

merged 4 commits into from
May 28, 2024

Conversation

cratelyn
Copy link
Contributor

💭 describe your changes

while debugging my work integrating mock consensus tests with the view server,
it was helpful to add additional instrumentation to some relevant parts of the
penumbra-view crate. this branch adds some useful spans and events.

🔖 issue ticket number and link

this branch contains preliminary changes related to #3913. see also, #4447.

✅ checklist before requesting a review

  • if this code contains consensus-breaking changes, i have added the
    "consensus-breaking" label. otherwise, i declare my belief that there are not
    consensus-breaking changes, for the following reason:

    this only makes changes to tracing events, and makes a small syntactic
    change. no behavior changes here should affect consensus.

@cratelyn cratelyn added the A-mock-consensus Area: Relates to the mock consensus engine label May 24, 2024
@cratelyn cratelyn added this to the Sprint 7 milestone May 24, 2024
@cratelyn cratelyn self-assigned this May 24, 2024
cratelyn added a commit that referenced this pull request May 24, 2024
@cratelyn
app: 📺 test that Planner can spend notes via mock consensus
3d78c52 
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
This was referenced May 24, 2024
Merged
Closed
@cratelyn cratelyn marked this pull request as ready for review May 24, 2024 20:05
erwanor
erwanor approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@erwanor erwanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cratelyn cratelyn merged commit a0306b8 into main May 28, 2024
13 checks passed
@cratelyn cratelyn deleted the kate/add-view-telemetry branch May 28, 2024 13:24
cratelyn added a commit that referenced this pull request May 29, 2024
@cratelyn
app: 📺 test that Planner can spend notes via mock consensus
0d82c26 
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
cratelyn added a commit that referenced this pull request May 30, 2024
@cratelyn
app: 📺 test that Planner can spend notes via mock consensus
4cdeb6f 
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
cratelyn added a commit that referenced this pull request May 31, 2024
@cratelyn
app: 📺 test that Planner can spend notes via mock consensus
2b60d55 
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
cratelyn added a commit that referenced this pull request May 31, 2024
@cratelyn
app: 📺 test that Planner can spend notes via mock consensus
1dab144 
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
cratelyn added a commit that referenced this pull request Jun 3, 2024
@cratelyn
app: 📺 test that Planner can spend notes via mock consensus
7521990 
see #3913.

this is the exciting culmination of work in pr's #3996, #4349, #4435,
 #4447, #4460, and #4468.

this adds a mock consensus test that spawns a gRPC server, creates a
view server, and then plans a transaction using the `Planner`. the
effects of this are then observed using the `ViewClient`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwanor erwanor erwanor approved these changes

Assignees

@cratelyn cratelyn

Labels
A-mock-consensus Area: Relates to the mock consensus engine
Projects
Penumbra
Status: Done
Milestone
Sprint 7
Development

Successfully merging this pull request may close these issues.
2 participants
@cratelyn @erwanor