Add ID filtering to AuctionsRequest; add local_seq to AuctionsResponse #4472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
force-pushed
the
jessepinho/auctions-rpc
branch
from
e6e59cd to
cab5ea7
Compare
jessepinho
commented
May 24, 2024
| // | ||
| // Dutch auctions move from: | ||
| // 0 (opened) => 1 (closed) => n (withdrawn) | ||
| uint64 local_seq = 5; |
There was a problem hiding this comment.
note_record above uses 4, which is why this field uses 5
There was a problem hiding this comment.
oh strange, could you move it so that they're ordered 🙏
cratelyn
added
protobuf-changes
|
did async review post merge and LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR makes two changes:
auction_ids_filtertoAuctionsRequest, so that clients can make requests (e.g., withqueryLatestState) for just specific auctions rather than all auctions at once.local_seqproperty toAuctionsResponseto indicate the local view service's own knowledge of the sequence number for an auction. (See pcli: auction end-all, withdraw-all #4385 (comment).)Relevant changes are to the protobuf here, plus a couple TODO items here and here.
Issue ticket number and link
penumbra-zone/web#1059 and #4385 (comment)
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: