Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add dex dashboard #4491

Merged
merged 1 commit into from
May 28, 2024
Merged

metrics: add dex dashboard #4491

merged 1 commit into from
May 28, 2024

Conversation

conorsch
Copy link
Contributor

Describe your changes

Adds a new hand-written dashboard to display DEX event durations. We're still massaging the bucketing logic, but getting this dashboard into version-control immediately, so we can iterate on it.

Issue ticket number and link

Refs #4464.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    no app code changes, metrics display only

Refs #4464. Adds a new hand-written dashboard to display DEX event
durations. We're still massaging the bucketing logic, but getting this
dashboard into version-control immediately, so we can iterate on it.
@conorsch conorsch requested a review from cratelyn May 28, 2024 17:42
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah-ha! that's where these live. thanks @conorsch!

@conorsch
Copy link
Contributor Author

The testnet deployment pins a tag, but I manually modified it to use a container built from this branch, so the new dashboard is live immediately. In strict adherence to process, we should cherry-pick this onto a release-branch to make sure it's included in the next point release, but I'm not going to do that now: instead, I'm going to focus on planning the next release, be that a point release or another chain upgrade in the near future.

@conorsch conorsch merged commit 8bcbb40 into main May 28, 2024
16 checks passed
@conorsch conorsch deleted the grafana-dex-dashboard branch May 28, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants