Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dex: update bucket values #4502

Merged
merged 1 commit into from
May 30, 2024
Merged

dex: update bucket values #4502

merged 1 commit into from
May 30, 2024

Conversation

hdevalence
Copy link
Member

Describe your changes

change buckets to 16 log spaced values between 5 and 250

Issue ticket number and link

#4464

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    metrics changes only

@hdevalence hdevalence requested a review from cratelyn May 30, 2024 02:23
@cratelyn cratelyn merged commit cfad432 into main May 30, 2024
13 checks passed
@cratelyn cratelyn deleted the dex-buckets branch May 30, 2024 04:31
@cratelyn cratelyn mentioned this pull request May 30, 2024
Closed
1 task
cratelyn added a commit that referenced this pull request Jun 3, 2024
@cratelyn
dex: 🧮 shift dex buckets over by a factor of 1000
a267e84 
`metrics` histograms use seconds as a unit of measurement, update the
bucket configuration to reflect that.

see:
* #4502
* #4464
@cratelyn cratelyn mentioned this pull request Jun 3, 2024
Merged
1 task
cratelyn added a commit that referenced this pull request Jun 3, 2024
@cratelyn
dex: 🧮 shift dex buckets over by a factor of 1000
f35b190 
`metrics` histograms use seconds as a unit of measurement, update the
bucket configuration to reflect that.

see:
* #4502
* #4464
conorsch pushed a commit that referenced this pull request Jun 3, 2024
@cratelyn @conorsch
dex: 🧮 shift dex buckets over by a factor of 1000
0a58ee3 
`metrics` histograms use seconds as a unit of measurement, update the
bucket configuration to reflect that.

see:
* #4502
* #4464

(cherry picked from commit f35b190)
@conorsch conorsch mentioned this pull request Jun 3, 2024
Merged
1 task
conorsch pushed a commit that referenced this pull request Jun 3, 2024
@cratelyn @conorsch
dex: 🧮 shift dex buckets over by a factor of 1000
4ebd75d 
`metrics` histograms use seconds as a unit of measurement, update the
bucket configuration to reflect that.

see:
* #4502
* #4464

(cherry picked from commit f35b190)
@cratelyn cratelyn mentioned this pull request Jun 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cratelyn cratelyn cratelyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Penumbra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdevalence @cratelyn