pd: add migration for testnet77 #4503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
reviewed
May 30, 2024
| @@ -22,7 +22,7 @@ use once_cell::sync::Lazy; | |||
|
|
|||
| /// Representation of the Penumbra application version. Notably, this is distinct | |||
| /// from the crate version(s). This number should only ever be incremented. | |||
| pub const APP_VERSION: u64 = 5; | |||
| pub const APP_VERSION: u64 = 6; | |||
| .get_block_height() | ||
| .await | ||
| .expect("chain state has a block height"); | ||
| let post_upgrade_height = pre_upgrade_height.wrapping_add(1); |
There was a problem hiding this comment.
I think we're missing creating the StateDelta and calling delta.ready_to_start() + commit in place, unless my eyes betray me
erwanor
approved these changes
May 30, 2024
Adds a new migration, which resets the halt bit. No other migration logic is required, as no state-breaking changes are slated for testnet 77. This way, we preserve `pd migrate` as the default invocation for node operators. Also changed here are the APP_VERSION and corresponding docs entries. Refs #4497.
conorsch
force-pushed
the
migration-for-77
branch
from
a8c8f21 to
9cdbb99
Compare
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a new migration, which resets the halt bit. No other migration logic is required, as no state-breaking changes are slated for testnet 77. This way, we preserve
pd migrateas the default invocation for node operators. Also changed here are the APP_VERSION and corresponding docs entries.Issue ticket number and link
Refs #4497.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: