Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pd): reset app height in testnet 77 migration #4508

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented May 30, 2024

Describe your changes

Encountered CometBFT failure while testing chain resumption after applying testnet77 migration. Paired with @erwanor to resolve.

Issue ticket number and link

Refs #4497.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    fixes a migration for upcoming release, based on migration testing

Encountered CometBFT failure while testing chain resumption after
applying testnet77 migration. Paired with @erwanor to resolve.

Refs #4497.
@conorsch conorsch requested a review from erwanor May 30, 2024 19:50
@conorsch
Copy link
Contributor Author

Follow-up to #4503. Also mentioning #4294 as relevant.

@conorsch
Copy link
Contributor Author

Tested a migration from v0.76.0 to the fix-77-migration image built from this PR, worked! 👍

@conorsch conorsch merged commit 37b21cc into main May 30, 2024
16 checks passed
@conorsch conorsch deleted the fix-77-migration branch May 30, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants