Exclude IBC assets from TotalSupply if their denom metadata is nonexistent #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
pushed a commit
that referenced
this pull request
Jun 3, 2024
…stent (#4518) ## Describe your changes This changes the `TotalSupply` query to skip including assets when there is no denom metadata available, for example liquidity position NFTs. This is okay since these are mostly of interest to a single user rather than the market as a whole. I validated that the error when querying on the current v0.77.0 testnet goes away. ``` $ grpcurl -plaintext -vv localhost:8080 cosmos.bank.v1beta1.Query/TotalSupply ``` ## Issue ticket number and link ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > Changes RPC output only (cherry picked from commit 785ac6a)
1 task
conorsch
pushed a commit
that referenced
this pull request
Jun 3, 2024
…stent (#4518) ## Describe your changes This changes the `TotalSupply` query to skip including assets when there is no denom metadata available, for example liquidity position NFTs. This is okay since these are mostly of interest to a single user rather than the market as a whole. I validated that the error when querying on the current v0.77.0 testnet goes away. ``` $ grpcurl -plaintext -vv localhost:8080 cosmos.bank.v1beta1.Query/TotalSupply ``` ## Issue ticket number and link ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > Changes RPC output only (cherry picked from commit 785ac6a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This changes the
TotalSupplyquery to skip including assets when there is no denom metadata available, for example liquidity position NFTs. This is okay since these are mostly of interest to a single user rather than the market as a whole.I validated that the error when querying on the current v0.77.0 testnet goes away.
Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: