Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: 🟢 address warnings from galileo build #4519

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

cratelyn
Copy link
Contributor

💭 describe your changes

when galileo is built against the current contents of main, these warnings appear:

warning: method `init` is never used
  --> /penumbra/crates/core/component/shielded-pool/src/component/fmd.rs:79:8
   |
78 | pub(crate) trait ClueManagerInternal: ClueManager {
   |                  ------------------- method in this trait
79 |     fn init(&mut self) {
   |        ^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: `penumbra-shielded-pool` (lib) generated 1 warning
warning: method `get_position_count` is never used
  --> /penumbra/crates/core/component/dex/src/component/position_manager/counter.rs:14:14
   |
11 | pub(super) trait PositionCounterRead: StateRead {
   |                  ------------------- method in this trait
...
14 |     async fn get_position_count(&self, trading_pair: &TradingPair) -> u32 {
   |              ^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

warning: `penumbra-dex` (lib) generated 1 warning
warning: method `stream_dutch_state_by_trigger` is never used
   --> /penumbra/crates/core/component/auction/src/component/dutch_auction.rs:462:14
    |
444 | pub(crate) trait DutchAuctionData: StateRead {
    |                  ---------------- method in this trait
...
462 |     async fn stream_dutch_state_by_trigger(
    |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

warning: `penumbra-auction` (lib) generated 1 warning
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.12s
[Finished running. Exit status: 0]

this addresses those warnings.

✅ checklist before requesting a review

  • if this code contains consensus-breaking changes, i have added the
    "consensus-breaking" label. otherwise, i declare my belief that there are not
    consensus-breaking changes, for the following reason:

    this only removes dead code.

@cratelyn cratelyn added the C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking. label May 31, 2024
@cratelyn cratelyn self-assigned this May 31, 2024
@cratelyn cratelyn added this to the Sprint 7 milestone May 31, 2024
@cratelyn cratelyn marked this pull request as ready for review May 31, 2024 20:46
@cratelyn cratelyn force-pushed the kate/address-galileo-warnings branch from 058c116 to 3248a0e Compare June 3, 2024 13:31
@cratelyn
Copy link
Contributor Author

cratelyn commented Jun 3, 2024

CI is no longer passing after a rebase (???) so i'm going to mark this as a draft. there's some unfortunate interaction with cargo features here.

@cratelyn cratelyn marked this pull request as draft June 3, 2024 14:17
@cratelyn cratelyn force-pushed the kate/address-galileo-warnings branch from 3248a0e to 78ab41e Compare June 3, 2024 14:42
@cratelyn cratelyn marked this pull request as ready for review June 3, 2024 14:54
@cratelyn
Copy link
Contributor Author

cratelyn commented Jun 3, 2024

okay neato, ci is green again 🙌

@cratelyn cratelyn requested a review from erwanor June 3, 2024 14:54
@cratelyn cratelyn merged commit 988cf19 into main Jun 3, 2024
13 checks passed
@cratelyn cratelyn deleted the kate/address-galileo-warnings branch June 3, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants