Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex: 🧮 shift dex buckets over by a factor of 1000 #4524

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

cratelyn
Copy link
Contributor

@cratelyn cratelyn commented Jun 3, 2024

metrics histograms use seconds as a unit of measurement, update the bucket configuration to reflect that.

see:

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    telemetry configuration

`metrics` histograms use seconds as a unit of measurement, update the
bucket configuration to reflect that.

see:
* #4502
* #4464
@cratelyn cratelyn added A-telemetry Area: Metrics, logging, and other observability-related features A-dex Area: Relates to the dex C-bug Category: a bug labels Jun 3, 2024
@cratelyn cratelyn self-assigned this Jun 3, 2024
@cratelyn cratelyn added this to the Sprint 8 milestone Jun 3, 2024
@cratelyn cratelyn marked this pull request as ready for review June 3, 2024 15:52
@cratelyn cratelyn merged commit f35b190 into main Jun 3, 2024
13 checks passed
@cratelyn cratelyn deleted the kate/shift-dex-buckets branch June 3, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dex Area: Relates to the dex A-telemetry Area: Metrics, logging, and other observability-related features C-bug Category: a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants