Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex: 🧮 shift dex buckets over by a factor of 1000 #4530

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Jun 3, 2024

Describe your changes

This commit backports #4524 for inclusion in the upcoming v0.77.1 release.

metrics histograms use seconds as a unit of measurement, update the bucket configuration to reflect that.

see:

(cherry picked from commit f35b190)

Issue ticket number and link

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    metrics only

`metrics` histograms use seconds as a unit of measurement, update the
bucket configuration to reflect that.

see:
* #4502
* #4464

(cherry picked from commit f35b190)
@conorsch conorsch requested a review from cratelyn June 3, 2024 20:09
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for handling the task of backporting this @conorsch 🫡 💐

@cratelyn cratelyn added this to the Sprint 8 milestone Jun 3, 2024
@cratelyn cratelyn added A-telemetry Area: Metrics, logging, and other observability-related features A-dex Area: Relates to the dex labels Jun 3, 2024
@conorsch conorsch merged commit 4ebd75d into release/v0.77.x Jun 3, 2024
11 checks passed
@conorsch conorsch deleted the backport-dex-bucket-fix branch June 3, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dex Area: Relates to the dex A-telemetry Area: Metrics, logging, and other observability-related features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants