dex: correct placement of arb metrics emission #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We noticed there were no metrics being emitted for the cost of the arb search when no arb was found. This fixes that, and should be backported into the next point release.
erwanor
approved these changes
Jun 4, 2024
|
Thank you for fixing this |
erwanor
pushed a commit
that referenced
this pull request
Jun 4, 2024
We noticed there were no metrics being emitted for the cost of the arb search when no arb was found. This fixes that, and should be backported into the next point release. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > Only changes metrics emission
1 task
erwanor
pushed a commit
that referenced
this pull request
Jun 4, 2024
We noticed there were no metrics being emitted for the cost of the arb search when no arb was found. This fixes that, and should be backported into the next point release. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > Only changes metrics emission
conorsch
pushed a commit
that referenced
this pull request
Jun 4, 2024
We noticed there were no metrics being emitted for the cost of the arb search when no arb was found. This fixes that, and should be backported into the next point release. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > Only changes metrics emission
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We noticed there were no metrics being emitted for the cost of the arb search when no arb was found.
This fixes that, and should be backported into the next point release.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: