pcli: add options to pcli v address for displaying an FVK or generating a payment address from a provided FVK #4576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
approved these changes
Jun 7, 2024
cratelyn
added
the
A-client
conorsch
reviewed
Jun 10, 2024
displaying an FVK or generating a payment address from a provided FVK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a couple utility flags to
pcli v addressto assist in FVK verification (i.e. Alice can send Bob an FVK, Bob can send a message in a transaction memo to an address associated with that FVK, Alice can successfully read that memo with her FVK and return the same message to Bob, confirming the round-trip communication)If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: