Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in positions --include-closed and display multi-sided LPs consistently #4583

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

zbuc
Copy link
Member

@zbuc zbuc commented Jun 10, 2024

Describe your changes

This PR fixes a crash currently occurring when viewing withdrawn LPs in pcli. It also makes the display of positions involving unknown assets more consistent.

Issue ticket number and link

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    only pcli display changes

@zbuc zbuc merged commit a4bede1 into main Jun 11, 2024
13 checks passed
@zbuc zbuc deleted the small_pcli_lp_viewfix branch June 11, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants