pcli: 🌷 add a top-level --grpc-url override
#4585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustfmt is reticent to format attributes. let's indent this conventionally.
when a pcli user initializes their configuration, they provide the `init` command with the grpc url of a fullnode, which is stored in pcli's configuration file. by default, this is found at `~/.local/share/pcli/config.toml`. if that fullnode is later encountering issues, this can render many pcli commands unusable, without a clear workaround. this is a small patch, providing a top-level `--grpc-url` option that will override the config file's GRPC url. this can help users temporarily send requests to a different fullnode, until their preferred default comes back online.
cratelyn
added
the
A-client
|
this is a great ux improvement! |
cronokirby
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a pcli user initializes their configuration, they provide the
initcommand with the grpc url of a fullnode, which is stored in pcli's configuration file. by default, this is found at~/.local/share/pcli/config.toml.if that fullnode is later encountering issues, this can render many pcli commands unusable, without a clear workaround. this is a small patch, providing a top-level
--grpc-urloption that will override the config file's GRPC url.this can help users temporarily send requests to a different fullnode, until their preferred default comes back online.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: