Add leave-archive flag to pd join
#4607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
approved these changes
Jun 13, 2024
crates/bin/pd/src/testnet/join.rs
Outdated
Comment on lines
314
to
319
| if !leave_archive { | ||
| // Post-extraction, clean up the downloaded tarball. | ||
| std::fs::remove_file(archive_filepath)?; | ||
| } |
There was a problem hiding this comment.
it would be nice to complement this with an else { tracing::info!(?path = archive_filepath, "leaving downloaded archive on disk"); } branch to point users at the location of the tarball, for the sake of facilitating copy-pasting and saving someone the trouble of going looking for it.
There was a problem hiding this comment.
Great suggestion, I tacked this on just now after testing locally.
includes a log message that displays the path if the flag is set.
conorsch
force-pushed
the
pd_join_leave_archive
branch
from
deff2d4 to
cad7320
Compare
Downloading gigabytes of archive data while testing locally then seeing it deleted and having to do it again is a powerful motivator 😅 |
|
Is there a way to point the join command at the existing archive file on disk? I didn't check that |
|
Wow yeah I would really like being able to install an archive from disk |
|
Right now loading archives from a local doesn't work: but we should be able to tweak the scheme, give me a moment... |
|
Done. I overloaded the |
Saves the need to download a multi-gigabyte file, especially while testing.
conorsch
force-pushed
the
pd_join_leave_archive
branch
from
4252af1 to
8f2e870
Compare
conorsch
added a commit
that referenced
this pull request
Jun 13, 2024
Follow-up to #4607. This fix is required to preserve the original downloading from URL behavior. Both file:// and https:// URLs must remain supported. Must have accidentally rebased this diff out while collborating on 4607.
1 task
conorsch
added a commit
that referenced
this pull request
Jun 13, 2024
Follow-up to #4607. This fix is required to preserve the original downloading from URL behavior. Both file:// and https:// URLs must remain supported. Must have accidentally rebased this diff out while collborating on 4607.
conorsch
added a commit
that referenced
this pull request
Jun 13, 2024
Follow-up to #4607. This fix is required to preserve the original downloading from URL behavior. Both file:// and https:// URLs must remain supported. Must have accidentally rebased this diff out while collborating on 4607.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Small change to add a
--leave-archiveflag topd join(defaults to false) to optionally leave behind the downloaded archive file.Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: