auction: dex-enabled check during LP allocation #4621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
added
consensus-breaking
erwanor
changed the title
conorsch
reviewed
Jun 17, 2024
| .get_raw(&state_key::position_by_id(id)) | ||
| .await? | ||
| .is_some()) | ||
| async fn check_position_by_id(&self, id: &position::Id) -> bool { |
There was a problem hiding this comment.
Why the change to a raw bool return type? With this change, we must use expect which will panic rather than return an error which can be handled more gracefully by callers.
There was a problem hiding this comment.
This is infallible unless the application state is corrupted, in that case there are no way to recover, so we do want to stop everything. So in effect, the Result here is superfluous, on the other hand it has a real cost of making the API unwieldy.
zbuc
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Close #4599
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: