Split CloseAll/WithdrawAll iteration into chunks to prevent planner failures #4642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
approved these changes
Jun 19, 2024
conorsch
pushed a commit
that referenced
this pull request
Jun 20, 2024
…ailures (#4642) ## Describe your changes The `pcli tx position close-all` and `pcli tx position withdraw-all` commands were failing to plan for me when I had a significant (100+) number of positions. This PR splits them into chunks, currently 30 positions, and fixed the planning failures for me. ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > pcli only (cherry picked from commit 1693c20)
conorsch
pushed a commit
that referenced
this pull request
Jun 20, 2024
…ailures (#4642) ## Describe your changes The `pcli tx position close-all` and `pcli tx position withdraw-all` commands were failing to plan for me when I had a significant (100+) number of positions. This PR splits them into chunks, currently 30 positions, and fixed the planning failures for me. ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > pcli only (cherry picked from commit 1693c20)
conorsch
pushed a commit
that referenced
this pull request
Jun 20, 2024
…ailures (#4642) ## Describe your changes The `pcli tx position close-all` and `pcli tx position withdraw-all` commands were failing to plan for me when I had a significant (100+) number of positions. This PR splits them into chunks, currently 30 positions, and fixed the planning failures for me. ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > pcli only (cherry picked from commit 1693c20)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The
pcli tx position close-allandpcli tx position withdraw-allcommands were failing to plan for me when I had a significant (100+) number of positions.This PR splits them into chunks, currently 30 positions, and fixed the planning failures for me.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: