ibc: fix logging of timestamp timeouts #4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
approved these changes
Jun 24, 2024
zbuc
requested changes
Jun 24, 2024
Signed-off-by: Chris Czub <chris@penumbralabs.xyz>
zbuc
approved these changes
Jun 24, 2024
conorsch
approved these changes
Jun 24, 2024
|
I just noticed that the timestamp used here is wrong, it should be using the consensus state timestamp. will fix |
avahowell
force-pushed
the
ibc-logging-typo-fix
branch
from
ef6e114 to
6e09f66
Compare
|
should be ready now |
conorsch
added
the
consensus-breaking
|
Marking this as consensus-breaking after the fact, because the diff makes substantive changes to how timeouts are handled. Please remove the label if inappropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.