Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delegator vote to TxPlannerReq #4689

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Add delegator vote to TxPlannerReq #4689

merged 1 commit into from
Jul 3, 2024

Conversation

grod220
Copy link
Contributor

@grod220 grod220 commented Jul 2, 2024

Web consumer uses TransactionPlannerRequest to initiate planning between frontend<->extension. To support delegator voting, we'd need to add to this protobuf definition.

This reflects the way the core repo assembles a plan: https://github.com/penumbra-zone/penumbra/blob/main/crates/bin/pcli/src/command/tx.rs#L899-L938

@plaidfinch, thoughts?

@plaidfinch
Copy link
Collaborator

This looks right to me. This is just the implementation of the proto, right? So we then would also need to implement the part that responds appropriately to the request?

@grod220 grod220 marked this pull request as ready for review July 2, 2024 16:40
@grod220
Copy link
Contributor Author

grod220 commented Jul 2, 2024

@plaidfinch the web stack appears to be the only consumer of TransactionPlannerRequest (given the frontend and extension are separate systems). Pcli doesn't issue this request, but directly interacts with the planner for Delegator Voting.

@grod220 grod220 force-pushed the delegator-vote-req branch from aec09b2 to e3ff75f Compare July 3, 2024 07:00
@grod220 grod220 merged commit a7e9d81 into main Jul 3, 2024
13 checks passed
@grod220 grod220 deleted the delegator-vote-req branch July 3, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants