Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add timestamp indexing wip #4713

Merged
merged 8 commits into from
Jul 19, 2024

Conversation

vacekj
Copy link
Member

@vacekj vacekj commented Jul 16, 2024

Describe your changes

Issue ticket number and link

fixes #4675

@vacekj vacekj linked an issue Jul 16, 2024 that may be closed by this pull request
@cronokirby
Copy link
Contributor

I think we want to instead add a timestamp into: https://buf.build/penumbra-zone/penumbra/docs/main:penumbra.core.component.sct.v1#penumbra.core.component.sct.v1.EventBlockRoot

@vacekj vacekj force-pushed the 4675-pindexer-add-appview-mapping-height-to-timestamps branch from 85bce6c to 7cb7bf5 Compare July 18, 2024 16:00
@vacekj vacekj force-pushed the 4675-pindexer-add-appview-mapping-height-to-timestamps branch from 1a4f305 to 9e7985b Compare July 19, 2024 14:23
@vacekj vacekj marked this pull request as ready for review July 19, 2024 14:48
Copy link
Contributor

@cronokirby cronokirby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; maybe let's just move block/block.rs into block.rs? We can change this as we have other things.

@vacekj vacekj merged commit 7142295 into main Jul 19, 2024
13 checks passed
@vacekj vacekj deleted the 4675-pindexer-add-appview-mapping-height-to-timestamps branch July 19, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pindexer: ⏰ add AppView mapping height to timestamps
2 participants